Skip to content

fix(helm-chart): allow empty values#2491

Merged
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:helm-charts-allow-empty-values
Oct 29, 2025
Merged

fix(helm-chart): allow empty values#2491
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:helm-charts-allow-empty-values

Conversation

@Piskoo

@Piskoo Piskoo commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Fixed an issue where attesting Helm charts with empty values.yaml files would fail with an EOF error, even though this is valid according to Helm specifications.

The validation logic now distinguishes between Chart.yaml (requires content) and values.yaml (can be empty).
Closes #2488

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo marked this pull request as ready for review October 29, 2025 10:32
@jiparis

jiparis commented Oct 29, 2025

Copy link
Copy Markdown
Member

Thanks for the quick fix!

@Piskoo Piskoo merged commit 5e06e78 into chainloop-dev:main Oct 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to attest Helm chart with empty values file

2 participants