Skip to content

fix(attestation): material annotations output#2502

Merged
migmartri merged 1 commit into
chainloop-dev:mainfrom
Piskoo:revert-hiding-legacy-annotations
Oct 31, 2025
Merged

fix(attestation): material annotations output#2502
migmartri merged 1 commit into
chainloop-dev:mainfrom
Piskoo:revert-hiding-legacy-annotations

Conversation

@Piskoo

@Piskoo Piskoo commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Fixed regression introduced in #2481 where legacy annotations were filtered out in att add and att status.

@Piskoo
fix regression
4803b59 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo

Piskoo commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Should we introduce new annotation for materials that use only one tool as well?
cc/ @javirln @migmartri @jiparis

@Piskoo Piskoo marked this pull request as ready for review October 30, 2025 10:36
@migmartri

migmartri commented Oct 30, 2025

Copy link
Copy Markdown
Member

Sorry I don't have enough context, what happened, what was lost?

@Piskoo

Piskoo commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry I don't have enough context, what happened, what was lost?

I've added new chainloop.material.tools annotation for cdx and spdx files and filtered out chainloop.material.tools.Version/Name annotations in att init/status output, but crafter for some other material types also extracts tool used to the annotation, therefore the issue and my follow up question.

jiparis
jiparis reviewed Oct 30, 2025
View reviewed changes
Comment thread app/cli/cmd/attestation_add.go
if len(status.Material.Annotations) > 0 {
mt.AppendRow(table.Row{"Annotations", "------"})
for _, a := range status.Material.Annotations {
if materials.IsLegacyAnnotation(a.Name) {

@jiparis jiparis Oct 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove this method, since it's not used anymore.

@jiparis

jiparis commented Oct 30, 2025

Copy link
Copy Markdown
Member

Should we introduce new annotation for materials that use only one tool as well? cc/ @javirln @migmartri @jiparis

Do you mean in the command output? If the output is going to be duplicated, I don't think so.

@migmartri migmartri merged commit 6cf51f7 into chainloop-dev:main Oct 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiparis jiparis jiparis left review comments
@migmartri migmartri migmartri approved these changes
@javirln javirln Awaiting requested review from javirln

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piskoo @migmartri @jiparis