fix(craftingschema): move annotations to spec#2620
Merged
Conversation
jiparis
approved these changes
Dec 15, 2025
migmartri
reviewed
Dec 15, 2025
| annotations: | ||
| - name: version | ||
| value: "1.0.0" | ||
| - name: team |
Member
There was a problem hiding this comment.
does this work by only providing the name not the value, so the value is recovered at runtime?
Contributor
Author
There was a problem hiding this comment.
Yes, the annotation value is required if it wasn't provided in the contract
$ cl att push
WRN API contacted in insecure mode
ERR annotations ["environment"] required
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs fixes the placement of attestation-level annotations in the v2 schema moving them back to spec like in v1 schema.