Skip to content

fix(craftingschema): move annotations to spec#2620

Merged
Piskoo merged 1 commit into
chainloop-dev:mainfrom
Piskoo:pfm-4081
Dec 16, 2025
Merged

fix(craftingschema): move annotations to spec#2620
Piskoo merged 1 commit into
chainloop-dev:mainfrom
Piskoo:pfm-4081

Conversation

@Piskoo

@Piskoo Piskoo commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

This PRs fixes the placement of attestation-level annotations in the v2 schema moving them back to spec like in v1 schema.

apiVersion: chainloop.dev/v1
kind: Contract
metadata:
  name: chainloop-contract
spec:
  annotations:
    - name: environment
    # value is empty so environment will have to be specified during attestation process

@Piskoo Piskoo marked this pull request as ready for review December 15, 2025 15:47
annotations:
- name: version
value: "1.0.0"
- name: team

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work by only providing the name not the value, so the value is recovered at runtime?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the annotation value is required if it wasn't provided in the contract

$ cl att push
WRN API contacted in insecure mode
ERR annotations ["environment"] required

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo merged commit d08a596 into chainloop-dev:main Dec 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants