fix(pr-metadata): Make PR metadata collection work with remote states#2648
Merged
Merged
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
approved these changes
Jan 8, 2026
jiparis
reviewed
Jan 8, 2026
| // AutoCollectPRMetadata automatically collects PR/MR metadata if running in a PR/MR context | ||
| func (c *Crafter) AutoCollectPRMetadata(ctx context.Context, attestationID string, runner SupportedRunner, casBackend *casclient.CASBackend) error { | ||
| if err := c.requireStateLoaded(); err != nil { | ||
| return fmt.Errorf("crafting state not loaded before inspecting PR/MR metadata: %w", err) |
Member
Author
There was a problem hiding this comment.
My take is that since it’s a public method on the crafter, it’s not guaranteed that it’s being called after a state has been loaded. Similarly, the other public methods that interact with the state have the guard, so I’ve added it here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
attestation init --remote-statein Dagger with PR context, the automatic PR metadata collection was failing with a digest mismatch error:This only affected remote attestations, not local filesystem-based ones.
Root Cause
Remote attestations use optimistic concurrency control with digest checksums. During
attestation init:ResolveEnvVars()modifies and saves state → server calculates new digestAutoCollectPRMetadata()attempts to save with stale digest → conflictThis issue didn't affect
attestation addorattestation pushbecause those commands reload state before modifying it.Solution
Added state reload at the beginning of
AutoCollectPRMetadata()to ensure the digest checksum is current before making modificationsTesting