feat(attestation): Make attestation view URL clickable in CI/CD reports#2677
Merged
Conversation
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Piskoo
approved these changes
Jan 21, 2026
javirln
reviewed
Jan 21, 2026
Comment on lines
+181
to
+183
| if attestationViewURL != "" { | ||
| content += fmt.Sprintf("\n[View Attestation Details](%s)\n", attestationViewURL) | ||
| } |
Member
There was a problem hiding this comment.
This and the one in GitLab will basically print twice the URL, once inside the table with the attestation status and then after the table was rendered as markdown, is that expected?
Member
Author
There was a problem hiding this comment.
I think so, I don't want to mess with the ascii table, I looked into changing the content inside but it will mess with its formatting, the solution in reality is to translate the whole table into markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary