Skip to content

fix(cas-redirection): Avoid returning URL when CAS is not valid #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javirln merged 4 commits into from
Mar 2, 2026
Merged

fix(cas-redirection): Avoid returning URL when CAS is not valid #2796

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d7f79
fix(cas-redirection): Avoid returning URL when CAS is not valid
javirln Feb 27, 2026
f56ffa9
code suggestions
javirln Feb 27, 2026
0fbf481
fix typo
javirln Feb 27, 2026
95497c8
remove regex
javirln Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/controlplane/internal/service/casredirect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2023 The Chainloop Authors.
// Copyright 2023-2026 The Chainloop Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -110,6 +110,11 @@ func (s *CASRedirectService) GetDownloadURL(ctx context.Context, req *pb.GetDown
return nil, kerrors.NotFound("not found", "CAS backend is inline")
}

// check if the backend is on a valid state, if not return an error
if backend.ValidationStatus != biz.CASBackendValidationOK {
return nil, pb.ErrorCasBackendErrorReasonInvalid("CAS Storage is in an invalid state and can't download artifacts, please fix it before attempting it again")
}

// Create an URL to download the artifact from the CAS backend
downloadBase, err := url.Parse(s.casServerConf.GetDownloadUrl())
if err != nil {
Expand Down
Loading