fix(chart): resolve Dex OIDC issuer URL mismatch in development mode#2838
Merged
Conversation
When installing with --set development=true, the controlplane panics because the OIDC issuer URL doesn't match what Dex reports (chainloop-dex-dex vs chainloop-dex). Remove redundant -dex suffix from the Dex external URL template and fix the parent chart's dexContext to use a synthetic chart name so common.names.fullname resolves correctly. Fixes chainloop-dev#2837 Signed-off-by: Miguel Martinez <miguel@chainloop.dev> Entire-Checkpoint: 07412b504e7d
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainloop-dex-dexinstead ofchainloop-dexwhen running with--set development=true-dexsuffix from the Dex external URL template sincechainloop.dex.fullnamealready resolves tochainloop-dex$dexContextto use a synthetic chart name (dex) socommon.names.fullnameresolves tochainloop-dexconsistently across both subchart and parent chart contextsFixes #2837