Skip to content

chore: upgrade go to 1.26.1 #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
migmartri merged 8 commits into from
Mar 13, 2026
Merged

chore: upgrade go to 1.26.1 #2839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be7f7bc
upgrade go to 1.26.1
jiparis Mar 12, 2026
6388905
upgrade dagger
jiparis Mar 12, 2026
123472f
upgrade lint
jiparis Mar 12, 2026
61a54ef
Revert "upgrade lint"
jiparis Mar 13, 2026
3660357
Revert "upgrade dagger"
jiparis Mar 13, 2026
37cdcc4
undo dagger changes
jiparis Mar 13, 2026
b8ec2b5
fix
jiparis Mar 13, 2026
a5ce0a5
update skill
jiparis Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions .claude/skills/upgrading-golang/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,35 +51,26 @@ With:
FROM golang:X.XX.X@sha256:NEW_DIGEST AS builder
```

### 5. Update GitHub Actions

Update `go-version` in all workflow YAML files. See [files-to-update.md](files-to-update.md) for the complete list.

Pattern to replace:
```yaml
go-version: "X.XX.X"
```

### 6. Update Documentation
### 5. Update Documentation

@cubic-dev-ai cubic-dev-ai Bot Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This change drops the GitHub Actions update step, so the Go upgrade instructions are now incomplete and can leave CI running the old Go version.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .claude/skills/upgrading-golang/SKILL.md, line 54:

<comment>This change drops the GitHub Actions update step, so the Go upgrade instructions are now incomplete and can leave CI running the old Go version.</comment>

<file context>
@@ -51,35 +51,26 @@ With:
-```
-
-### 6. Update Documentation
+### 5. Update Documentation
 
 Update the version reference in `./CLAUDE.md` under "Key Technologies":
</file context>
Fix with Cubic


Update the version reference in `./CLAUDE.md` under "Key Technologies":
```markdown
- **Language**: Go X.XX.X. To know how to upgrade go version, see docs/runbooks
```

### 7. Update Atlas Docker Image and CLI (Optional)
### 6. Update Atlas Docker Image and CLI (Optional)

If the user requested an Atlas upgrade:

**7a. Pull the Atlas Docker image and extract its SHA256 digest:**
**6a. Pull the Atlas Docker image and extract its SHA256 digest:**

```bash
docker pull arigaio/atlas:X.XX.X
```

Extract the SHA256 digest from the output (format: `sha256:abc123...`).

**7b. Update `./app/controlplane/Dockerfile.migrations`:**
**6b. Update `./app/controlplane/Dockerfile.migrations`:**

Pattern to replace:
```dockerfile
Expand Down Expand Up @@ -119,7 +110,7 @@ With the new version (note: use `v` prefix for the version):
curl -sSf https://atlasgo.sh | ATLAS_VERSION=vX.XX.X sh -s -- -y
```

### 8. Verify Changes
### 7. Verify Changes

Run verification commands:
```bash
Expand All @@ -129,7 +120,7 @@ make lint

If errors occur, address them before completing the upgrade.

### 9. Final Checks
### 8. Final Checks

- Ensure all license headers are updated (2024 → 2024-2025 or add current year)
- Run `buf format -w` if any proto files were affected
Expand Down
14 changes: 0 additions & 14 deletions .claude/skills/upgrading-golang/files-to-update.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,20 +43,6 @@ FROM arigaio/atlas@sha256:DIGEST as base
curl -sSf https://atlasgo.sh | ATLAS_VERSION=vX.XX.X sh -s -- -y
```

## CI/CD Workflows

### GitHub Actions
- `./.github/workflows/lint.yml`
- `./.github/workflows/test.yml`
- `./.github/workflows/release.yaml`
- `./.github/workflows/codeql.yml`
- `./docs/examples/ci-workflows/github.yaml`

Update pattern in all:
```yaml
go-version: "X.XX.X"
```

## Documentation

### Project Documentation
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ make migration_lint # Lint migration files

## Key Technologies

- **Language**: Go 1.26.0
- **Language**: Go 1.26.1
- **API**: gRPC with HTTP/JSON gateway, Protocol Buffers with buf
- **Database**: PostgreSQL with Ent ORM, Atlas for migrations
- **Authentication**: OIDC, JWT tokens
Expand Down
2 changes: 1 addition & 1 deletion app/artifact-cas/Dockerfile.goreleaser
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.26.0@sha256:75ca321c953ce0572c709fa186cff872a510a22d6dad515291c6eb29edb9c849 AS builder
FROM golang:1.26.1@sha256:c7e98cc0fd4dfb71ee7465fee6c9a5f079163307e4bf141b336bb9dae00159a5 AS builder

FROM scratch

Expand Down
2 changes: 1 addition & 1 deletion app/cli/Dockerfile.goreleaser
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.26.0@sha256:75ca321c953ce0572c709fa186cff872a510a22d6dad515291c6eb29edb9c849 AS builder
FROM golang:1.26.1@sha256:c7e98cc0fd4dfb71ee7465fee6c9a5f079163307e4bf141b336bb9dae00159a5 AS builder
RUN mkdir -p /.config/chainloop

FROM scratch
Expand Down
2 changes: 1 addition & 1 deletion app/controlplane/Dockerfile.goreleaser
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.26.0@sha256:75ca321c953ce0572c709fa186cff872a510a22d6dad515291c6eb29edb9c849 AS builder
FROM golang:1.26.1@sha256:c7e98cc0fd4dfb71ee7465fee6c9a5f079163307e4bf141b336bb9dae00159a5 AS builder

FROM scratch

Expand Down
2 changes: 1 addition & 1 deletion common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ init: init-api-tools
# in the community version anymore https://github.com/ariga/atlas/issues/2388#issuecomment-1864287189
# install golangci-lint with Go 1.25 support
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin v2.4.0
curl -sSf https://atlasgo.sh | ATLAS_VERSION=v1.1.0 sh -s -- -y
curl -sSf https://atlasgo.sh | ATLAS_VERSION=v1.1.3 sh -s -- -y

# initialize API tooling
.PHONY: init-api-tools
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/chainloop-dev/chainloop

go 1.26.0
go 1.26.1

require (
cloud.google.com/go/secretmanager v1.16.0
Expand Down
Loading