Skip to content

chore(ci): migrate secrets-scan-daily workflow to GitHub keyless auth#2844

Merged
matiasinsaurralde merged 1 commit into
chainloop-dev:mainfrom
matiasinsaurralde:chore/secrets-scan-daily-keyless-migration
Mar 14, 2026
Merged

chore(ci): migrate secrets-scan-daily workflow to GitHub keyless auth#2844
matiasinsaurralde merged 1 commit into
chainloop-dev:mainfrom
matiasinsaurralde:chore/secrets-scan-daily-keyless-migration

Conversation

@matiasinsaurralde

Copy link
Copy Markdown
Contributor

Summary

Signed-off-by: Matías Insaurralde <matias@chainloop.dev>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/secrets-scan-daily.yml">

<violation number="1" location=".github/workflows/secrets-scan-daily.yml:19">
P2: Keep `GITHUB_TOKEN` in this env block so attestation init can still verify the head commit through the GitHub API.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment on lines +19 to +20
CHAINLOOP_WORKFLOW_NAME: "daily-secrets-detection"
CHAINLOOP_PROJECT_NAME: "chainloop"

@cubic-dev-ai cubic-dev-ai Bot Mar 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Keep GITHUB_TOKEN in this env block so attestation init can still verify the head commit through the GitHub API.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/secrets-scan-daily.yml, line 19:

<comment>Keep `GITHUB_TOKEN` in this env block so attestation init can still verify the head commit through the GitHub API.</comment>

<file context>
@@ -6,29 +6,18 @@ on:
-      CHAINLOOP_WORKFLOW_NAME: ${{ needs.onboard_workflow.outputs.workflow_name }}
-      CHAINLOOP_PROJECT_NAME: ${{ needs.onboard_workflow.outputs.project_name }}
-      GITHUB_TOKEN: ${{ github.token }}
+      CHAINLOOP_WORKFLOW_NAME: "daily-secrets-detection"
+      CHAINLOOP_PROJECT_NAME: "chainloop"
 
</file context>
Suggested change
CHAINLOOP_WORKFLOW_NAME: "daily-secrets-detection"
CHAINLOOP_PROJECT_NAME: "chainloop"
CHAINLOOP_WORKFLOW_NAME: "daily-secrets-detection"
CHAINLOOP_PROJECT_NAME: "chainloop"
GITHUB_TOKEN: ${{ github.token }}
Fix with Cubic

@matiasinsaurralde matiasinsaurralde merged commit 3decc9d into chainloop-dev:main Mar 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants