-
Notifications
You must be signed in to change notification settings - Fork 53
feat: add reviewers to PR metadata #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8b87add
feat: add reviewers to PR metadata
jiparis de0dba9
fix: address PR review feedback
jiparis 85d8e71
fix: use envVars map instead of os.Getenv for GitLab reviewer vars
jiparis b41a71e
fix: add reviewer-related env vars to GitLab and Dagger ListEnvVars
jiparis a39f549
fix: use os.Getenv for CI_JOB_TOKEN to avoid persisting it in attesta…
jiparis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
internal/schemavalidators/internal_schemas/prinfo/pr-info-1.1.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "https://schemas.chainloop.dev/prinfo/1.1/pr-info.schema.json", | ||
| "properties": { | ||
| "platform": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "github", | ||
| "gitlab" | ||
| ], | ||
| "description": "The CI/CD platform" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "pull_request", | ||
| "merge_request" | ||
| ], | ||
| "description": "The type of change request" | ||
| }, | ||
| "number": { | ||
| "type": "string", | ||
| "description": "The PR/MR number or identifier" | ||
| }, | ||
| "title": { | ||
| "type": "string", | ||
| "description": "The PR/MR title" | ||
| }, | ||
| "description": { | ||
| "type": "string", | ||
| "description": "The PR/MR description or body" | ||
| }, | ||
| "source_branch": { | ||
| "type": "string", | ||
| "description": "The source branch name" | ||
| }, | ||
| "target_branch": { | ||
| "type": "string", | ||
| "description": "The target branch name" | ||
| }, | ||
| "url": { | ||
| "type": "string", | ||
| "format": "uri", | ||
| "description": "Direct URL to the PR/MR" | ||
| }, | ||
| "author": { | ||
| "type": "string", | ||
| "description": "Username of the PR/MR author" | ||
| }, | ||
| "reviewers": { | ||
| "items": { | ||
| "properties": { | ||
| "login": { | ||
| "type": "string", | ||
| "description": "Username of the reviewer" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "User", | ||
| "Bot", | ||
| "unknown" | ||
| ], | ||
| "description": "Account type of the reviewer" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "type": "object", | ||
| "required": [ | ||
| "login", | ||
| "type" | ||
| ] | ||
| }, | ||
| "type": "array", | ||
| "description": "List of reviewers who reviewed or were requested to review" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "type": "object", | ||
| "required": [ | ||
| "platform", | ||
| "type", | ||
| "number", | ||
| "url" | ||
| ], | ||
| "title": "Pull Request / Merge Request Information", | ||
| "description": "Schema for Pull Request or Merge Request metadata collected during attestation" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.