fix(cas): move CORS config under server.http#2858
Merged
Merged
Conversation
The CORS configuration was placed at the server level instead of under server.http, causing it to not be loaded correctly in production. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
The CORS field was moved from Server to Server.HTTP in the proto, which triggers buf's FIELD_NO_DELETE rule. Add an ignore_only exception for this internal config proto. Signed-off-by: Miguel Martinez <miguel@chainloop.dev> Entire-Checkpoint: 657a990875a2
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="buf.yaml">
<violation number="1" location="buf.yaml:35">
P2: This file-wide `FIELD_NO_DELETE` ignore disables breaking-change checks for all future config-field deletions in `conf.proto`, not just the CORS move.
(Based on your team's feedback about cross-component and version compatibility.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - EXTENSION_NO_DELETE | ||
| - FIELD_SAME_DEFAULT | ||
| ignore_only: | ||
| FIELD_NO_DELETE: |
There was a problem hiding this comment.
P2: This file-wide FIELD_NO_DELETE ignore disables breaking-change checks for all future config-field deletions in conf.proto, not just the CORS move.
(Based on your team's feedback about cross-component and version compatibility.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At buf.yaml, line 35:
<comment>This file-wide `FIELD_NO_DELETE` ignore disables breaking-change checks for all future config-field deletions in `conf.proto`, not just the CORS move.
(Based on your team's feedback about cross-component and version compatibility.) </comment>
<file context>
@@ -31,6 +31,9 @@ modules:
- EXTENSION_NO_DELETE
- FIELD_SAME_DEFAULT
+ ignore_only:
+ FIELD_NO_DELETE:
+ - app/artifact-cas/internal/conf/conf.proto
- path: app/controlplane/api
</file context>
jiparis
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.corstoserver.http.corsin the proto definition and Helm template so it is correctly loaded in production deploymentsrefs #2848