Skip to content

feat: add kind field to AI agent config files#2865

Merged
jiparis merged 4 commits into
chainloop-dev:mainfrom
jiparis:jiparis/ai-agent-config-kind
Mar 17, 2026
Merged

feat: add kind field to AI agent config files#2865
jiparis merged 4 commits into
chainloop-dev:mainfrom
jiparis:jiparis/ai-agent-config-kind

Conversation

@jiparis

@jiparis jiparis commented Mar 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a kind field to each detected configuration file in the AI agent config collectors
  • Files are classified as "configuration" (settings.json, .mcp.json) or "instruction" (CLAUDE.md, rules, agents, commands)
  • This enables fine-tuning policies based on file purpose

Ref: PFM-4969

Add a "kind" field to each detected configuration file in the AI agent
config collectors, classifying files as either "configuration" (settings,
JSON configs) or "instruction" (markdown rules, agents, commands).

Ref: PFM-4969
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from Piskoo, javirln and migmartri March 16, 2026 17:56

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/schemavalidators/internal_schemas/aiagentconfig/ai-agent-config-0.1.schema.json">

<violation number="1" location="internal/schemavalidators/internal_schemas/aiagentconfig/ai-agent-config-0.1.schema.json:68">
P1: Making `kind` required changes the 0.1 schema incompatibly without a schema version bump. Older 0.1 payloads will now fail validation even though the schema ID and file name still advertise 0.1.

(Based on your team's feedback about ensuring cross-component and version compatibility.) [FEEDBACK_USED]</violation>
</file>

<file name="internal/aiagentconfig/discover.go">

<violation number="1" location="internal/aiagentconfig/discover.go:41">
P2: Avoid adding wildcard-based discovery patterns here; this package should use explicit directory traversal/path checks instead of glob matching.

(Based on your team's feedback about avoiding glob patterns in file discovery and path matching.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread internal/aiagentconfig/discover.go
jiparis added 3 commits March 17, 2026 00:48
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit 7b0148e into chainloop-dev:main Mar 17, 2026
15 checks passed
@jiparis jiparis deleted the jiparis/ai-agent-config-kind branch March 17, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants