feat: add kind field to AI agent config files#2865
Merged
jiparis merged 4 commits intoMar 17, 2026
Conversation
Add a "kind" field to each detected configuration file in the AI agent config collectors, classifying files as either "configuration" (settings, JSON configs) or "instruction" (markdown rules, agents, commands). Ref: PFM-4969 Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/schemavalidators/internal_schemas/aiagentconfig/ai-agent-config-0.1.schema.json">
<violation number="1" location="internal/schemavalidators/internal_schemas/aiagentconfig/ai-agent-config-0.1.schema.json:68">
P1: Making `kind` required changes the 0.1 schema incompatibly without a schema version bump. Older 0.1 payloads will now fail validation even though the schema ID and file name still advertise 0.1.
(Based on your team's feedback about ensuring cross-component and version compatibility.) [FEEDBACK_USED]</violation>
</file>
<file name="internal/aiagentconfig/discover.go">
<violation number="1" location="internal/aiagentconfig/discover.go:41">
P2: Avoid adding wildcard-based discovery patterns here; this package should use explicit directory traversal/path checks instead of glob matching.
(Based on your team's feedback about avoiding glob patterns in file discovery and path matching.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
migmartri
approved these changes
Mar 16, 2026
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kindfield to each detected configuration file in the AI agent config collectors"configuration"(settings.json, .mcp.json) or"instruction"(CLAUDE.md, rules, agents, commands)Ref: PFM-4969