fix(cas): handle client disconnect errors gracefully in download service#2882
Merged
Conversation
Client disconnects (connection reset by peer, broken pipe) during HTTP downloads were being logged as errors and reported to Sentry. These are normal operational events that should be logged at info level instead. Refs: PFM-5015 Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
Author
|
All CI checks are green. This PR is blocked on branch protection — requires an approving review before merge. Ready for human approval. |
migmartri
removed
multiclaude
javirln
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isClientDisconnecthelper that detects client disconnections:context.Canceled, gRPC canceled status,ECONNRESET(connection reset by peer), andEPIPE(broken pipe)io.Copyto response writer) — previously these errors were logged as errors and sent to SentryFixes #2883