feat(materials): extract structured MCP server info from AI agent config#2904
Merged
Merged
Conversation
Parse .mcp.json and settings.json to populate the mcp_servers field with structured data (server name, command, args, URL, transport type). Environment variable values are stripped for security — only key names are retained. The raw .mcp.json file is no longer collected in config_files to prevent leaking sensitive data like API keys. Closes chainloop-dev#2888 Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/aiagentconfig/aiagentconfig.go">
<violation number="1" location="internal/aiagentconfig/aiagentconfig.go:70">
P2: Remove `omitempty` from the `disabled` boolean so `false` is serialized explicitly.
(Based on your team's feedback about preferring explicit states over omitting boolean false values.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
matiasinsaurralde
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mcp.jsonand.claude/settings.jsonto populate themcp_serversfield with structured data (server name, command, args, URL, disabled status), allowing the creation of policies that evaluate used MCP services.env_keys.mcp.jsonfrom rawconfig_filescollection to prevent leaking sensitive data (API keys, tokens)MCPServerstruct replacing theanyplaceholder, with corresponding JSON schema validationsafeReadFilehelper to consolidate the symlink-resolve, path-verify, read-file sequenceCloses #2888