fix(attestation): make AI agent config collector deterministic#2911
Merged
jiparis merged 2 commits intoMar 21, 2026
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/attestation/crafter/crafter.go">
<violation number="1" location="pkg/attestation/crafter/crafter.go:148">
P2: Returning on reload failure inside the collector loop aborts remaining collectors and breaks the function’s best-effort contract.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Use attestation InitializedAt timestamp for CapturedAt instead of time.Now(), ensuring the same content is produced on retries. Also replace RegisterCollectors append with reset to prevent duplicate collectors, and move LoadCraftingState inside the per-collector loop so each collector sees the latest state. Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
jiparis
force-pushed
the
jiparis/fix-remote-att-materials
branch
from
4cefee5 to
954221e
Compare
migmartri
approved these changes
Mar 21, 2026
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitializedAttimestamp for the AI configCapturedAtfield instead oftime.Now(), so retries produce identical content and CAS digestsRegisterCollectorsappend semantics with reset to prevent duplicate collectors on repeated callsLoadCraftingStateinside the per-collector loop so each collector operates on the latest remote stateFixes PFM-5122