fix(ci): pin GitHub Actions to SHA digests#2920
Merged
migmartri merged 6 commits intoMar 22, 2026
Merged
Conversation
Pin all external GitHub Action references to commit SHA digests instead of mutable version tags to prevent supply chain attacks via tag reassignment. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Add Chainloop contract and GitHub Actions workflow for PR attestation on the chainloop-platform project. Enforces commit signatures, PR description quality, and GitHub issue linking. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/pr_validation.yaml">
<violation number="1" location=".github/workflows/pr_validation.yaml:18">
P2: Avoid granting `id-token: write` at workflow scope; set minimal workflow permissions and declare `id-token: write` on the specific job that needs it.
(Based on your team's feedback about GitHub Actions permissions scoping.) [FEEDBACK_USED]</violation>
<violation number="2" location=".github/workflows/pr_validation.yaml:36">
P1: Pin and verify the Chainloop CLI installation instead of executing an unpinned remote script, otherwise the installed binary can change unexpectedly between runs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
jiparis
approved these changes
Mar 22, 2026
Move permissions to job level with read-all at workflow level, remove --collectors aiconfig flag, and fix project name to chainloop. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
OIDC id-token is not available for fork PRs, making keyless attestation impossible for external contributions. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2921
Summary
chainloop-chainloop-github-releasecontract