Skip to content

feat: add policyEvaluationsCount and policyViolationsCount to attestation predicate #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
migmartri merged 1 commit into from
Apr 1, 2026
Merged

feat: add policyEvaluationsCount and policyViolationsCount to attestation predicate #2976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions app/controlplane/api/controlplane/v1/response_messages.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions app/controlplane/api/controlplane/v1/response_messages.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ message AttestationItem {
bool blocked = 3;
bool has_violations = 4;
bool has_gated_violations = 5;
// Total number of policy evaluations
int32 evaluations_count = 6;
// Total number of policy violations across all evaluations
int32 violations_count = 7;
}

message EnvVariable {
Expand Down
40 changes: 39 additions & 1 deletion app/controlplane/api/gen/frontend/controlplane/v1/response_messages.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions ...api/gen/jsonschema/controlplane.v1.AttestationItem.PolicyEvaluationStatus.jsonschema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions ...ane/api/gen/jsonschema/controlplane.v1.AttestationItem.PolicyEvaluationStatus.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions app/controlplane/internal/service/attestation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,8 @@ func bizAttestationToPb(att *biz.Attestation, predicate chainloop.NormalizablePr
Blocked: policyEvaluationStatus.Blocked,
HasViolations: policyEvaluationStatus.HasViolations,
HasGatedViolations: policyEvaluationStatus.HasGatedViolations,
EvaluationsCount: int32(policyEvaluationStatus.EvaluationsCount),
ViolationsCount: int32(policyEvaluationStatus.ViolationsCount),
},
Bundle: att.Bundle,
}, nil
Expand Down
4 changes: 4 additions & 0 deletions pkg/attestation/renderer/chainloop/chainloop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ type PolicyEvaluationStatus struct {
HasViolations bool
// Whether the attestation has gated policy violations
HasGatedViolations bool
// Total number of policy evaluations
EvaluationsCount int
// Total number of policy violations across all evaluations
ViolationsCount int
}

type NormalizedMaterial struct {
Expand Down
2 changes: 2 additions & 0 deletions pkg/attestation/renderer/chainloop/testdata/attestation.output-2.v0.2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@
"policyAttBlocked": false,
"policyBlockBypassEnabled": false,
"policyCheckBlockingStrategy": "ADVISORY",
"policyEvaluationsCount": 0,
"policyHasViolations": false,
"policyViolationsCount": 0,
"runnerType": "RUNNER_TYPE_UNSPECIFIED"
}
}
2 changes: 2 additions & 0 deletions pkg/attestation/renderer/chainloop/testdata/attestation.output-2.v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@
"policyAttBlocked": false,
"policyBlockBypassEnabled": false,
"policyCheckBlockingStrategy": "ADVISORY",
"policyEvaluationsCount": 0,
"policyHasViolations": false,
"policyViolationsCount": 0,
"runnerType": "RUNNER_TYPE_UNSPECIFIED"
}
}
2 changes: 2 additions & 0 deletions pkg/attestation/renderer/chainloop/testdata/attestation.output.v0.2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@
}
]
},
"policyEvaluationsCount": 1,
"policyHasViolations": true,
"policyViolationsCount": 1,
"runnerType": "GITHUB_ACTION"
}
}
2 changes: 2 additions & 0 deletions pkg/attestation/renderer/chainloop/testdata/attestation.output.v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@
}
]
},
"policyEvaluationsCount": 1,
"policyHasViolations": true,
"policyViolationsCount": 1,
"runnerType": "GITHUB_ACTION"
}
}
Loading
Loading