feat(cache): add configurable JetStream KV replica count

[jiparis]

Summary

• Add WithReplicas option to pkg/cache so NATS JetStream KV buckets can be created with a configurable replica count. Max 3 replicas
• Thread replica count from Helm values → proto config → natsconn.Config → ReloadableConnection → attestationbundle/policyevalbundle caches
• Fixes inconsistent reads in clustered NATS deployments where KV buckets defaulted to 1 replica

Follow-up of PFM-5440.

[cubic-dev-ai]

1 issue found across 12 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="deployment/chainloop/values.yaml">

<violation number="1" location="deployment/chainloop/values.yaml:197">
P3: Bump the Helm chart patch version in Chart.yaml when updating values.yaml so chart consumers can pick up the change.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

1 issue found across 12 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="pkg/natsconn/natsconn.go">

<violation number="1" location="pkg/natsconn/natsconn.go:57">
P2: `Replicas` is documented as defaulting to 1, but `New` passes through `cfg.Replicas` without applying that default.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P2: Replicas is documented as defaulting to 1, but New passes through cfg.Replicas without applying that default.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At pkg/natsconn/natsconn.go, line 57:

<comment>`Replicas` is documented as defaulting to 1, but `New` passes through `cfg.Replicas` without applying that default.</comment>

<file context>
@@ -52,7 +54,7 @@ func New(cfg *Config, logger log.Logger) (*ReloadableConnection, func(), error)
 
 	l := log.NewHelper(log.With(logger, "component", "natsconn"))
-	rc := &ReloadableConnection{logger: l}
+	rc := &ReloadableConnection{logger: l, Replicas: cfg.Replicas}
 
 	opts := []nats.Option{
</file context>

Suggested change

	rc := &ReloadableConnection{logger: l, Replicas: cfg.Replicas}
	replicas := cfg.Replicas
	if replicas <= 0 {
	replicas = 1
	}
	rc := &ReloadableConnection{logger: l, Replicas: replicas}