fix(verifier): return typed errors from timestamp verification#3038
Merged
jiparis merged 2 commits intoApr 16, 2026
Merged
Conversation
Replace the opaque "some timestamps verification failed" message with typed sentinel errors so callers (and Sentry) can identify the exact failure mode without string matching: - ErrTSAResponseInvalid — RFC3161 response rejected by TSA chain - ErrTimestampOutsideTSAValidity — timestamp outside cert validity window - ErrSigningCertNotValidAtTimestamp — signing cert not valid at timestamp time - ErrNoTSARootsConfigured — bundle has timestamps but server has no TSA roots Also hoists sb.VerificationContent() out of the per-TSA inner loop (pre-existing inefficiency) and returns early on the first failed timestamp instead of accumulating counts. Relates to CONTROL-PLANE-5V Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve control plane error reporting when TSA verification fails.
Closes #3039
Summary
ErrTSAResponseInvalid,ErrTimestampOutsideTSAValidity,ErrSigningCertNotValidAtTimestamp,ErrNoTSARootsConfigured) so callers and Sentry can identify the exact failure mode viaerrors.Issb.VerificationContent()out of the per-TSA inner loop (pre-existing inefficiency)