Skip to content

feat: add billing account resource type and roles to membership model#3040

Closed
Piskoo wants to merge 1 commit into
chainloop-dev:mainfrom
Piskoo:pfm-5575
Closed

feat: add billing account resource type and roles to membership model#3040
Piskoo wants to merge 1 commit into
chainloop-dev:mainfrom
Piskoo:pfm-5575

Conversation

@Piskoo

@Piskoo Piskoo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

This PR extends the membership model to support billing accounts as a resource type. Adds Owner and Admin roles for billing account access control.

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

RoleProductAdmin Role = "role:product:admin"

// BillingAccount roles
RoleBillingAccountOwner Role = "role:billing_account:owner"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed here? in this codebase? cc/ @jiparis

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as RoleProductAdmin/RoleProductViewer - defined here because the membership schema lives here

@Piskoo Piskoo marked this pull request as ready for review April 20, 2026 09:11
@Piskoo Piskoo closed this Apr 21, 2026
@Piskoo

Piskoo commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Closing as discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants