fix(attestation): decode DSSE signature at bundle source#3060
Merged
migmartri merged 2 commits intoApr 20, 2026
Merged
Conversation
Move the double-base64 fix into BundleFromDSSEEnvelope so new Sigstore bundles carry a properly decoded signature by construction. FixSignatureInBundle is retained in the verifier for backward compatibility with attestations stored before the fix. Promote the envelope-to-bundle test helper to the shared testhelpers package so other biz integration tests can reuse it. Follow-up to chainloop-dev#3055. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
- Guard BundleFromDSSEEnvelope against empty DSSE Signatures slice. - Trim narrative comment on BundleBytesFromEnvelope testhelper. - Deduplicate attestations_test.go with a shared test envelope helper; add explicit no-signatures and no-op cases. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jiparis
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3056 addressing review comments.
BundleFromDSSEEnvelope, so new Sigstore bundles are correct by construction. This was the cleanup the original TODO tracked against the removal ofAttestationServiceStoreRequest.Bundle.FixSignatureInBundlecall from the CLI push path; it is retained in the verifier to continue handling attestations stored before the fix, and its godoc is updated to reflect that.workflowrun_integration_test.gotoapp/controlplane/pkg/biz/testhelpersso other biz integration tests can reuse it.Related to #3055