perf: use hex.EncodeToString instead of fmt.Sprintf("%x", ...)#3132
Merged
Conversation
Replace fmt.Sprintf("%x", ...) hex-encoding calls with
hex.EncodeToString, which avoids fmt reflection and is
faster on hot paths (digest checksums, signing key IDs).
Signed-off-by: Matías Insaurralde <matias@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jiparis
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
fmt.Sprintf("%x", ...)hex-encoding calls withhex.EncodeToStringacross the CAS, CLI, control plane signing, and attestation verifier code paths.hex.EncodeToStringavoids thefmtreflection machinery and is roughly 5x faster, which matters on hot paths such as per-chunk checksum stringification in the CAS bytestream service and per-certificate key-ID derivation in signing and verification.