feat: org setting to block attestations on released versions#3175
Merged
migmartri merged 4 commits intoJun 9, 2026
Merged
Conversation
Add an opt-in organization-level setting, block_attestations_on_released_versions, that rejects new attestations targeting project versions that are already released (prerelease == false). Default is false, preserving current behavior. Enforcement happens at two points: at attestation init, transactionally with a row lock when resolving the project version, providing fail-fast feedback before any work is done; and at push in SaveAttestation, which acts as the authoritative gate closing the window where a version could be released between init and push. Both return a dedicated typed error mapped to a FailedPrecondition gRPC code so the CLI surfaces a clear message. The setting is exposed through the organization settings API and the chainloop organization update CLI command. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: 146f4ecb-bdc9-4562-8b1b-2481ea10d7bf
Contributor
AI Session Analysis
|
| Status | Policy | Material | Messages |
|---|---|---|---|
| ✅ Passed | ai-config-ai-agents-allowed |
ai-coding-session-146f4e |
- |
| ✅ Passed | ai-config-no-dangerous-commands |
ai-coding-session-146f4e |
- |
ai-config-no-secrets |
ai-coding-session-146f4e |
Potential secret (Quoted API key/password) found in session content [turn=130, source=tool_result, line=58, value=PASSWORD...ase"] | |
| ✅ Passed | ai-config-mcp-servers-allowed |
ai-coding-session-146f4e |
- |
Powered by Chainloop and Chainloop Trace
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 37 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Surface the org-level setting in `chainloop organization describe` so admins can confirm whether the guard is enabled. Rendered only when on, matching the existing selective output style. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: 146f4ecb-bdc9-4562-8b1b-2481ea10d7bf
Add codes.FailedPrecondition to the set of gRPC codes whose server message is surfaced verbatim, stripping the wrapped chain prefix. This makes the released-version immutability error read as a clear, actionable message on both attestation init and push. Also align the organization describe output to use a colon separator for the policy strategy line, consistent with the other settings rows. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: 146f4ecb-bdc9-4562-8b1b-2481ea10d7bf
The push-side guard previously read the project version's release status and then persisted the attestation in separate operations, leaving a TOCTOU window where a concurrent release could be bypassed (identified by cubic). Move the prerelease check into the persistence transaction and lock the project version row (FOR UPDATE) so the check and the attestation write are atomic and serialized against a concurrent release. The organization setting is resolved up front and threaded into the repo persistence methods, matching how the init path already passes the flag down. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: 146f4ecb-bdc9-4562-8b1b-2481ea10d7bf
javirln
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in organization-level setting,
block_attestations_on_released_versions, that prevents new attestations from being pushed to project versions that are already released (prerelease == false). The default isfalse, so existing behavior is unchanged.When enabled, attempting to attest against a released version fails hard with a dedicated typed error mapped to a
FailedPreconditiongRPC code, so the CLI can render a clear, actionable message.Enforcement
The guard is applied at two points:
SaveAttestation) — the authoritative gate that closes the window where a version could be released concurrently between init and push.Exposure
The setting is exposed through the organization settings API and the
chainloop organization update --block-attestations-on-released-versionsCLI command.Closes #3174
AI assistance disclosure
This contribution was assisted by Claude Code.