fix: enforce positive token list limits#11
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a minimum value validator (min=1) to the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Added a small follow-up to address the pre-merge warning: |
Summary
min=1validation to all token listing--limitoptions0and negative values before the command reaches token fetchingCloses #4
Testing
uv run pytest tests/test_commands/test_smoke.py -quv run ruff check src/ tests/uv run pytest tests/ -qSummary by CodeRabbit
Improvements
Tests