fix(compiler): set jsxFramework in test configs so JSX extraction runs#3635
Merged
segunadebayo merged 1 commit intoJun 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Adebesin-Cell is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@pandacss/compilertest suite has been failing onv2since June 3, and CI doesn't catch it. This sets the one config field that fixes it.What's wrong
JSX extraction is gated on
config.jsxFramework(crates/pandacss_project/src/config.rs): no framework, no JSX scanning. That gate landed on 2026-06-03 (12e4c46fb). The compiler test configs setjsxFactorybut neverjsxFramework, so from that commit on, every JSX-dependent test inpackages/compiler/__tests__returns empty JSX and fails. Thepandacss_extractorcrate tests pass because they enable the framework explicitly, so the engine itself is fine — only the JS test configs are stale.It went unnoticed because CI runs root
pnpm test, and the root vitest config excludespackages/compiler/__tests__/**. The suite only runs viapnpm --filter @pandacss/compiler test, which CI never invokes. So it's been green in CI and red locally for months.The fix
Set
jsxFramework: 'react'in the test configs that exercise JSX — the sharedcreateUserConfigand the inline configs incallbacks,recipes, andproject. Most snapshots already expected the JSX-derived atoms; they just weren't being produced. One snapshot legitimately changes: a framework-enabled project now generatestypes/jsx.d.ts, so it's added to the codegen-artifacts list.pnpm --filter @pandacss/compiler testgoes from 24 failing to 0 (199 passing).Follow-up worth considering
Add the
@pandacss/compilersuite to CI (it isn't run today) so this can't silently regress again. Left out of this PR to keep it focused.