Open
Conversation
…o bst Merging branch bst.
…o bst sdf building a binary search tree.
…ctures into traversal-bst g g Lines starting with '#' will be ignocquire post_order_trav. red, and an empty message aborts
Bl41r
reviewed
Jan 23, 2017
| """ | ||
| if self.root is None: | ||
| return 0 | ||
| return self.calc_depth(self.root.right) - self.calc_depth(self.root.left) |
There was a problem hiding this comment.
According to specs, left heavy is positive
Bl41r
reviewed
Jan 23, 2017
| return 0 | ||
| return self.calc_depth(self.root.right) - self.calc_depth(self.root.left) | ||
|
|
||
| def in_order(self): |
There was a problem hiding this comment.
I personally like how you are able to have both the generator method, and also be able to simply return the value
Bl41r
reviewed
Jan 23, 2017
| self.insert(value) | ||
| except TypeError: | ||
| self.insert(if_iter) | ||
| self._in_order = self.in_order_trav() |
There was a problem hiding this comment.
What happens if you create a tree with some nodes in it, but then start a traversal, and then add nodes into it before you have completed it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.