You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are already able to submit suggestion code with github-review however a specific syntax needs to be followed. This PR adds a new public function that you can call with your cursor placed at the loc you want to suggest so it will create a suggestion box for you.
I was just going to open an issue for how to format suggestions or if they work with github-review, but looks like you've addressed that here. I couldn't find an example anywhere for how to format suggestions and I tried this as a quick test, but it didn't translate correctly and wasn't sure why:
I was just going to open an issue for how to format suggestions or if they work with github-review, but looks like you've addressed that here. I couldn't find an example anywhere for how to format suggestions and I tried this as a quick test, but it didn't translate correctly and wasn't sure why:
@JSpenced you don't need the final ``` marks because this will be sent as a continuation of the string above and probably will translate with extras ``` in the suggestion box in github UI.
Okay, thanks for letting me know. Also, I noticed it is weird about spaces versus tabs for adding the line after suggestion. It seemed to not align right if I used spaces, but I saw how you were copying the line in this PR and when I copied the line/spacing it seemed to align the text correctly. Anyways, thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are already able to submit suggestion code with
github-reviewhowever a specific syntax needs to be followed. This PR adds a new public function that you can call with your cursor placed at the loc you want to suggest so it will create a suggestion box for you.turns into: