Over current error code by AravindSubramanian752 · Pull Request #63 · charinev/unified-error-codes

AravindSubramanian752 · 2026-07-12T19:42:08Z

Definitions and telemetry push

AravindSubramanian752 · 2026-07-12T20:44:39Z

+
+EVSE definition : This error code is set when the EVSE detects the Side B current exceeds the 
+maximum allowed Side B current threshold of the EVSE. 
+


Cannot include the scenario where the EVSE does not regulate current accurately to EV target, since as per iec that situation does not fall under "OverCurrent".

Does IEC specify the error code or scenario name for such situation? So that we can introduce dedicated error code with aligned naming.

If we are separating Side B or Side A - (also is it site or side) - we should consider renaming this to be more specific to the error message.

AravindSubramanian752 · 2026-07-12T20:46:41Z

+************************
+OverCurrent Location
+************************
+


Since we decided to make the side A fault as a different error code, i am making the location of the fault as if its set by the EV/ EVSE, rather than side or side b. Because as per definition this error code is only monitoring and measuring side B and will be set only if that side violates.

AravindSubramanian752 · 2026-07-12T20:47:21Z

+Trigger Conditions
+==================
+
+-  The EVSE trigger conditions and thresholds are as defined in the IEC 61851-23 standard, section CC.6.4.


Should we include requirements related to chademo or gbt?

Since this is CharIN, I think we should stay focused on CCS for now.

AravindSubramanian752 · 2026-07-12T20:47:38Z

+-  **Description**: The actual current measured at the over current location at the time of the over current condition.
+-  **Values**: Any positive numeric value representing the current in amperes.
+-  **Unit**: Amperes (A)
+-  **Resolution**: 0.1 A


Any thoughts on resolution?

I don't have any specific thoughts on this. 0.1 seems reasonably good, and we can always change it later.

knowack1

@AravindSubramanian752 thank you for the patch. Please find some comments from me and my AI.

knowack1 · 2026-07-13T07:29:43Z

+   SPDX-License-Identifier: CC-BY-4.0
+   Copyright CharIN e.V. and Contributors
+
+.. _error_overcurrent:


🟡 Label vs title inconsistency: label is _error_overcurrent while the title is OverCurrentFailure. The existing pattern keeps them aligned (ConnectorLockFailure → _error_connectorlockfailure). So the label name should be — _error_overcurrentfailure.

knowack1 · 2026-07-13T07:29:43Z

+.. _error_overcurrent:
+
+**********************
+ OverCurrentFailure


🟡 Filename convention: existing files follow definitions_<Title>.rst (e.g. definitions_ConnectorLockFailure.rst). This file is definitions_OverCurrent.rst but the title is OverCurrentFailure. Consider definitions_OverCurrentFailure.rst to match.

knowack1 · 2026-07-13T07:29:43Z

+Description
+===========
+
+EVSE definition : This error code is set when the EVSE detects the Side B current exceeds the 


🟢 Trailing whitespace here and on lines 15, 17, 21. Please strip.

knowack1 · 2026-07-13T07:29:43Z

+
+The following telemetry signals are required for analyzing this error:
+
+-  :ref:`telemetry_OverCurrent`


🟠 High: "Related Telemetry" lists only the Location signal, but this PR also defines Actual Current and Threshold Current — the essential values for an over-current diagnosis. Compare definitions_ConnectorLockFailure.rst, which references both of its signals. List all three (Location label per the naming note in the telemetry file):

- :ref:`telemetry_fault_location` - :ref:`telemetry_OverCurrent_ActualCurrent` - :ref:`telemetry_OverCurrent_ThresholdCurrent`

knowack1 · 2026-07-13T07:29:43Z

+   SPDX-License-Identifier: CC-BY-4.0
+   Copyright CharIN e.V. and Contributors
+
+.. _telemetry_OverCurrent:


🧭 Naming (supersedes an earlier suggestion of mine to nest this under _OverCurrent_): this Location signal — values EVSE / EV / unknown — is orthogonal to the fault type and reusable. ConnectorLockFailure ("either EV or EVSE") already wants the same thing. Give it a neutral label and title now, e.g. .. _telemetry_fault_location: / title "Fault Location" (or "Detection Side"), even while it physically stays in this file. Then promoting it to the generic definitions.rst later is a pure cut-and-paste with zero :ref: churn. Deferring the move is fine; deferring the name costs a breaking rename once refs point at it.

knowack1 · 2026-07-13T07:29:43Z

+.. _telemetry_OverCurrent:
+
+************************
+OverCurrent Location


🟢 Stylistic: existing telemetry files indent the title one space under the overline ( Connector Lock Position); these titles are flush-left. Worth matching for a clean diff.

knowack1 · 2026-07-13T07:29:43Z

+-  **Unit**: N/A
+-  **Resolution**: N/A
+
+.. _telemetry_OverCurrent_ActualCurrent:


The convention is to keep labels lowercase: _telemetry_over_current_actual_current.

However, I like your approach, as it provides a clean separation between the error code name and the value being measured.

What is inconsistent is starting with a lowercase letter while the subsequent parts are capitalized. Maybe the right way would be:
_telemetry_overCurrent_actualCurrent (my preferred approach)
or
_Telemetry_OverCurrent_ActualCurrent

Same comment for other labels.

knowack1 · 2026-07-13T07:29:43Z

+OverCurrent Location
+************************
+
+-  **Description**: The location of the over current condition. 


🟢 Trailing whitespace. Please strip.

Definitions and telemetry push

Aravind Subramanian added 3 commits July 12, 2026 15:41

Over current error code

6c7045b

Definitions and telemetry push

Over current error code

db0c7c7

Definitions and telemetry push

Over current error code

c6b7b1e

Definitions and telemetry push

AravindSubramanian752 commented Jul 12, 2026

View reviewed changes

AravindSubramanian752 requested review from knowack1 and plaskows83 July 12, 2026 20:48

knowack1 reviewed Jul 13, 2026

View reviewed changes

knowack1 requested changes Jul 13, 2026

View reviewed changes

AravindSubramanian752 linked an issue Jul 13, 2026 that may be closed by this pull request

Hardware Definition: OverCurrent #22

Open

Aravind Subramanian added 2 commits July 14, 2026 09:48

Over current error code

b016324

Definitions and telemetry push

Over current error code

28c2c53

Definitions and telemetry push


		EVSE definition : This error code is set when the EVSE detects the Side B current exceeds the
		maximum allowed Side B current threshold of the EVSE.


		The following telemetry signals are required for analyzing this error:

		- :ref:`telemetry_OverCurrent`

Uh oh!

Conversation

AravindSubramanian752 commented Jul 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knowack1 Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knowack1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

knowack1 Jul 13, 2026 •

edited

Loading

knowack1 left a comment •

edited

Loading