Add query counts and maximum queries to log configuration#74
Open
emilong wants to merge 3 commits intocharkost:mainfrom
Open
Add query counts and maximum queries to log configuration#74emilong wants to merge 3 commits intocharkost:mainfrom
emilong wants to merge 3 commits intocharkost:mainfrom
Conversation
K-S-A
approved these changes
Jan 5, 2024
|
Awesome idea! In fact, this should be a default configuration |
|
How can I help this to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using prosopite on an application with many N+1s, I wanted to focus my efforts on the N+1s with the most associated queries, so I added a count of queries.
I also found that I really only needed one query per N+1 to debug each issue, so I added a configuration to limit the number of queries logged.
The result looks something like this:
with this configuration:
I decided to make them both optional in case anyone depends on the existing format.