fix(list): RemoveItem correctly updates the filtered list when a filter is active#997
Open
troclaux wants to merge 1 commit into
Open
fix(list): RemoveItem correctly updates the filtered list when a filter is active#997troclaux wants to merge 1 commit into
troclaux wants to merge 1 commit into
Conversation
…er is active RemoveItem was removing by positional index from both the global items slice and the filteredItems slice. When a filter was applied those two indices do not correspond, so the wrong item could be dropped from the filtered list, or the filtered view could fail to reflect a removal that was visible inside it. Fix: iterate over filteredItems, skip the entry whose .index matches the removed global index, and decrement .index for every entry that follows the removed position. Fixes charmbracelet#632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632.
Problem
RemoveItem(index)used the sameindexfor two different purposes:m.items(whereindexis the global item position) ✓m.filteredItems(whereindexwas treated as a position in the filtered slice) ✗When a filter was applied, those two indices no longer correspond. Depending on the relative lengths, either the wrong filtered entry was removed, or a removal in the global list was not reflected in the filtered view.
Fix
Instead of removing by positional index from
filteredItems, iterate over the slice and:filteredItemwhose.indexfield matches the globalindexbeing removed..indexfor every subsequent entry (since they now point one position further than their actual global slot).The orphaned
removeFilterMatchFromSlicehelper is deleted.