fix(textarea): reposition view after SetValue#998
Open
troclaux wants to merge 1 commit into
Open
Conversation
SetValue was not scrolling the viewport to show the cursor after inserting content taller than the textarea height. Fixes charmbracelet#231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
SetValueis called with content taller than the textarea viewport, the viewport is not scrolled to show the cursor position. The cursor ends up on the last line of the content, butrepositionView()was never called to adjust the scroll offset.Fix
Call
m.repositionView()at the end ofSetValue, consistent with how other content-insertion paths work.Test
Added
TestSetValueViewportRepositionwhich sets a 3-line viewport, callsSetValuewith 5 lines, and asserts the cursor line is within the visible range.Fixes #231