fix(openai): don't double marshel responses api#293
Merged
Conversation
Member
Author
|
once this merges we need to properly handle CallWarnings in crush |
taciturnaxolotl
force-pushed
the
malformed-json-handling
branch
from
1877416 to
bc37950
Compare
Member
|
You'll need to re-record VCRs for this PR. Let me know if you need assistance with it. Also, make sure to test in Crush to ensure things keep working. Specially tool calls with arguments. |
taciturnaxolotl
force-pushed
the
malformed-json-handling
branch
from
bc37950 to
54e057b
Compare
taciturnaxolotl
changed the title
taciturnaxolotl
force-pushed
the
malformed-json-handling
branch
from
aaaf795 to
bae5145
Compare
taciturnaxolotl
force-pushed
the
malformed-json-handling
branch
from
d9f5aea to
f8d8f4c
Compare
taciturnaxolotl
force-pushed
the
malformed-json-handling
branch
from
f8d8f4c to
014ee08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the responses api was being double encoded improperly