Conversation
HashirA123
left a comment
There was a problem hiding this comment.
Changes look good to me. Would love for Zahra to approve as well if she gets the chance. Good catch with the LARR predict_proba comparison. I will check it out and edit as required for the future. Future todos look good too and make sense.
|
Thank you Chenghao, looks good. we are trying to see how the methods are running out of our repo so that we can improve the level of reproducibility. In the current version it seems that there are still some version conflicts. I am running on Python 3.12.10 and there are some packages that require lower versions of python like for nvidia-cufile-cu12 (I have sent the detailed error to you). Can you please check this? Or if you are using a different version of python please let me know. |
Refactor: Drop TensorFlow & Bump Dependencies
This PR drops TensorFlow support and bumps python to 3.12, torch to 2.10(+CUDA12.8).
Working Methods
The methods below are tested with linear target model (tree target model for feature_tweak) and breastcancer dataset, working fine.
Broken Methods
Fixes
data/causal_model/causal_model.pywith dependency injectmodels/catalog/utils.pywith dependency injectPossible Unfavorable/Ongoing Changes
methods/autoencoder/models/autoencoder.py)TODOs
Suggest to do items from up to down.
experiments/run_experiment.py, and possibly in methods' folders), then re-run all experimentsmethods/catalog/larr/model.py),preds_gpu_probs == 0compares float with int, which is possibly problematic and will causerecourse_needed_X_trainto be emptymethods/autoencoder/models/autoencoder.py)requirements-dev.txtandsetup.pyto their minimum, to reduce the risk of dependency incompatibility with other packages