Add IP address support with dclogin scheme to cmping

[Copilot]

• Update argument parsing to accept IP addresses in addition to domain names
• Add IP address detection logic (check if relay1/relay2 are IP addresses)
• Generate 12-character alphanumeric lowercase username for IP addresses
• Update AccountMaker.get_relay_account() to handle both domain names and IP addresses
• For IP addresses, use dclogin scheme with proper parameters (p, v, ip, sp, ic, ss)
• Pass linting checks
• Address code review feedback: improve account reuse for IP addresses
• Extract hardcoded port numbers and parameters to constants
• Refactor: Move _is_ip_address to standalone function
• Refactor: Extract common account lookup logic into _find_existing_account helper
• Refactor: Merge username and password generation into single _generate_credentials function
• Remove unnecessary URL encoding for password (only contains alphanumeric characters)
• Test the changes with both domain names and IP addresses

Original prompt

look at the definition of dclogin in https://github.com/deltachat/interface

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[hpk42]

@copilot look at the definition of dclogin in https://github.com/deltachat/interface and modify cmping.py to accept an IP address instead of a relay domain name. When an IP address is specified, use a 12 character long local name consisting of "a-z" and "0-9" characters. call the set_config_from_qr code with a "dclogin:" scheme like in this example: dclogin:lbcwz3c54s9n@172.238.97.168/?p=77d8rr624dkkxjedvv4g91i3&v=1&ip=993&sp=465&ic=3&ss=default

[Copilot]

@copilot look at the definition of dclogin in https://github.com/deltachat/interface and modify cmping.py to accept an IP address instead of a relay domain name. When an IP address is specified, use ...

Done! I've updated cmping.py to accept IP addresses and use the dclogin scheme as specified.

Key changes in commit a041f8b:

• Added IP address detection using Python's ipaddress module
• Generated 12-character alphanumeric lowercase usernames for IP addresses
• Implemented dclogin scheme with the parameters from your example: dclogin:username@ip/?p=password&v=1&ip=993&sp=465&ic=3&ss=default
• Account reuse logic checks the host part of configured addresses to reuse existing accounts for the same IP

The implementation follows the dclogin specification from deltachat/interface and maintains backward compatibility with domain-based configuration.

[hpk42]

@copilot move _is_ip_address out of the class into a single function

[Copilot]

@copilot move _is_ip_address out of the class into a single function

Done in commit 291c399. Moved _is_ip_address out of the AccountMaker class to a standalone function.

[hpk42]

@copilot simplify get_relay_account. refactor the common code like "for account in self.get_all_accounts" loop into a function and call it from both the "is ip_address" and "is not ip_address" branches

[Copilot]

@copilot simplify get_relay_account. refactor the common code like "for account in self.get_all_accounts" loop into a function and call it from both the "is ip_address" and "is not ip_address" branche...

Done in commit 18ba56a. Simplified get_relay_account by extracting the common account lookup loop into _find_existing_account helper method. The refactored code first checks for existing accounts (for both IP and domain cases), then only creates a new account if one isn't found.

[hpk42]

@copilot merge _generate_username and _generate_password into a single _generate_credentials function