fix(imex): transfer::get_backup must always free ongoing process#4249
Merged
link2xt merged 3 commits intostable-1.112from Mar 30, 2023
Merged
fix(imex): transfer::get_backup must always free ongoing process#4249link2xt merged 3 commits intostable-1.112from
link2xt merged 3 commits intostable-1.112from
Conversation
When the ongoing process is cancelled it is still the responsibility of whoever took out the ongoing process to free it. This code was only freeing the ongoing process when completed normally but not when cancelled.
Collaborator
|
I guess this PR isn't needed because of #4248? |
Contributor
Author
iequidoo
approved these changes
Mar 30, 2023
link2xt
approved these changes
Mar 30, 2023
Collaborator
|
Is it fixing #4192? |
Contributor
Author
I think it's part of it. But I'm not yet confident enough it fixes the entire issue and want to try do more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ongoing process is cancelled it is still the responsibility
of whoever took out the ongoing process to free it. This code was
only freeing the ongoing process when completed normally but not when
cancelled.