feat: Make it possible to specify IP addresses in dcaccount: scheme
#7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
commented
Jan 19, 2026
| if !param.dns_prefill.is_empty() { | ||
| let mut ips: Vec<IpAddr> = Vec::new(); | ||
| for ip in ¶m.dns_prefill { | ||
| match ip.parse::<IpAddr>() { |
Member
Author
There was a problem hiding this comment.
We could also already parse the IP addresses while parsing the QR code in login_param_from_account_qr.
Also, there is the question we should ignore invalid IP aggresses or if we should fail parsing the QR code if one address is invalid. Currently, it just emits an error event, but it continues with the rest of the IP addresses. Explicit error during parsing may be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcaccountsupports prefilling ip address into dns cache deltachat/interface#90closes #7705