Truncate messages on load and add an option to disable it #7749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/stop-message-truncation
branch
from
40ab705 to
1d1f074
Compare
Member
|
I think to merge this we need corresponding UI PRs, at least in iOS long messages were problematic in the past deltachat/deltachat-ios#1634 |
Contributor
|
moreover, we need to take care not to harm the existing, shipped ecosystem |
Collaborator
Author
|
We need corresponding Android PR. For Desktop, iOS, Ubuntu Touch, possible solution is to keep truncating the message, but on load rather than when saving to the database. |
link2xt
force-pushed
the
link2xt/stop-message-truncation
branch
2 times, most recently
from
ba78c68 to
567861b
Compare
link2xt
force-pushed
the
link2xt/stop-message-truncation
branch
from
567861b to
2366c33
Compare
link2xt
changed the title
link2xt
force-pushed
the
link2xt/stop-message-truncation
branch
from
09fbb95 to
16c2ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages are not converted to HTML when saving, but when loading.
There is a new API to disable truncation.
Closes #7718