feat: use more fitting encryption info message #7765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
commented
Jan 23, 2026
|
|
||
| /// The number of info messages added to new e2ee chats. | ||
| /// Currently this is "End-to-end encryption available", string `E2eAvailable`. | ||
| /// Currently this is "Messages are end-to-end encrypted.", string `ChatProtectionEnabled`. |
Contributor
Author
There was a problem hiding this comment.
this comment was always wrong
r10s
commented
Jan 23, 2026
| E2eAvailable = 25, | ||
|
|
||
| #[strum(props(fallback = "No encryption"))] | ||
| #[strum(props(fallback = "No encryption."))] |
Contributor
Author
There was a problem hiding this comment.
examples say to use a dot, so add it to the fallback string as well (in practise, the string is anyway not translated yet)
iequidoo
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the encryption-info to use the string "Messages are end-to-end encrypted." instead of "End-to-end encryption available"
"available" is a bit vague, and comes from times of opportunistic encryption.
re-use the string anyway used for the info-message