Skip to content

Added additional volumes support#197

Open
jwbeech wants to merge 3 commits into
chatwoot:mainfrom
jwbeech:feature/additional-volumes
Open

Added additional volumes support#197
jwbeech wants to merge 3 commits into
chatwoot:mainfrom
jwbeech:feature/additional-volumes

Conversation

@jwbeech

@jwbeech jwbeech commented Mar 20, 2026

Copy link
Copy Markdown

Added basic support for additional volumes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 849443a1f3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +83 to +84
{{- with .Values.hooks.migrate.extraVolumeMounts }}
{{- toYaml . | nindent 12 }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mount extra migration volumes into the init-postgres step too

When hooks.migrate.extraVolumeMounts is used to supply file-backed Postgres settings (for example a custom CA or .pgpass), the migration hook can still fail before db-migrate-job starts: init-postgres in charts/chatwoot/templates/migrations-job.yaml runs pg_isready first, but these new mounts are only attached here to the main container. In that setup the init container cannot read the mounted files, so the Job never reaches the container that has the extra-volume support.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant