Feature: Allow configuring Helm hook weight via values#207
Open
jemsz95 wants to merge 1 commit into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b95ec7eba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Argo CD maps Helm hooks to its own hook system, translating hook-weight to sync-wave. Because of differences in execution timing, certain migration jobs can enter a deadlock: the sync cannot succeed until the migration runs, but the migration isn't executed until the sync succeeds. Making the hook weight configurable allows the migration to run after resources are synced but before the overall sync finishes.
jemsz95
force-pushed
the
push-zrnrkyzoosuv
branch
from
2b95ec7 to
582dadc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this needed
As written, the chart can't be installed by argo-cd. Argo-cd maps Helm hooks to its own hook system, translating hook-weight to sync-wave. Because of differences in execution timing, certain migration jobs can enter a deadlock: the sync cannot succeed until the migration runs, but the migration isn't executed until the sync succeeds.
Making the hook weight configurable allows the migration to run after resources are synced but before the overall sync finishes.
Using this in argo-cd
Using the following values ensures that the hooks run before the start of the second sync wave (i.e sync wave 1)