Skip to content

fix(parser): skip reading files larger than 5MB to prevent memory exh… #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gubarz merged 1 commit into from
May 31, 2026
Merged

fix(parser): skip reading files larger than 5MB to prevent memory exh… #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions pkg/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package parser

import (
"bytes"
"fmt"
"os"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -99,11 +100,13 @@ func parseFilesParallel(files []string) []parseResult {
var localDuplicates []DuplicateExport

for _, path := range fileChunk {
if data, err := os.ReadFile(path); err == nil && len(data) > 0 {
localParser.index = NewCheatIndex()
localParser.parseLines(path, data)
localCheats = append(localCheats, localParser.index.Cheats...)
localModules = mergeModules(localModules, &localDuplicates, localParser.index.Modules)
if info, err := os.Stat(path); err == nil && info.Size() <= 5*1024*1024 {
if data, err := os.ReadFile(path); err == nil && len(data) > 0 {
localParser.index = NewCheatIndex()
localParser.parseLines(path, data)
localCheats = append(localCheats, localParser.index.Cheats...)
localModules = mergeModules(localModules, &localDuplicates, localParser.index.Modules)
}
}
}
resultChan <- parseResult{cheats: localCheats, modules: localModules, duplicates: localDuplicates, errors: localParser.index.Errors}
Expand Down Expand Up @@ -163,6 +166,11 @@ func mergeModules(target map[string]*Module, duplicates *[]DuplicateExport, sour
// ParseSingleFile parses a single markdown file
func (p *Parser) ParseSingleFile(path string) (*CheatIndex, error) {
p.index.Root = path
if info, err := os.Stat(path); err != nil {
return nil, err
} else if info.Size() > 5*1024*1024 {
return nil, fmt.Errorf("file exceeds 5MB size limit")
}
data, err := os.ReadFile(path)
if err != nil {
return nil, err
Expand Down
Loading