Skip to content

fix(config): enforce stricter file permissions and drop CWD config load #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gubarz merged 1 commit into from
May 31, 2026
Merged

fix(config): enforce stricter file permissions and drop CWD config load #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ func configureViper() {
viper.AddConfigPath(filepath.Join(home, ".config", "cheatmd"))
viper.AddConfigPath(home)
}
viper.AddConfigPath(".")

viper.SetEnvPrefix("CHEATMD")
viper.AutomaticEnv()
Expand Down Expand Up @@ -229,12 +228,18 @@ func WriteDefaultConfig(path string) error {
if _, err := os.Stat(path); err == nil {
return fmt.Errorf("config already exists at %s", path)
}
if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
if err := os.MkdirAll(filepath.Dir(path), 0o700); err != nil {
return fmt.Errorf("create config dir: %w", err)
}
content := withCheatsPath(string(defaultConfigTemplate), DefaultCheatsDir())
if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
return fmt.Errorf("write config: %w", err)

tmpPath := path + ".tmp"
if err := os.WriteFile(tmpPath, []byte(content), 0o600); err != nil {
return fmt.Errorf("write temp config: %w", err)
}
if err := os.Rename(tmpPath, path); err != nil {
os.Remove(tmpPath)
return fmt.Errorf("rename config: %w", err)
}
return nil
}
Expand Down
Loading