Skip to content

fix(installer): limit tarball extraction size and file count #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gubarz merged 1 commit into from
May 31, 2026
Merged

fix(installer): limit tarball extraction size and file count #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions internal/installer/tarball.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ func extractMarkdownTarball(r io.Reader, subdir, dest string) (int, error) {
subdir = normalizeSubdir(subdir)

count := 0
var totalBytes int64
const maxFiles = 5000
const maxTotalBytes = 50 * 1024 * 1024 // 50MB
const maxFileSize = 5 * 1024 * 1024 // 5MB

tr := tar.NewReader(gz)
for {
hdr, err := tr.Next()
Expand All @@ -74,6 +79,18 @@ func extractMarkdownTarball(r io.Reader, subdir, dest string) (int, error) {
if !keep {
continue
}

if count >= maxFiles {
return count, fmt.Errorf("tarball exceeds maximum allowed files (%d)", maxFiles)
}
if hdr.Size > maxFileSize {
return count, fmt.Errorf("tar entry %q exceeds maximum file size (5MB)", hdr.Name)
}
totalBytes += hdr.Size
if totalBytes > maxTotalBytes {
return count, fmt.Errorf("tarball exceeds maximum extracted size (50MB)")
}

if err := writeTarEntry(tr, hdr, dest, rel); err != nil {
return count, err
}
Expand Down
Loading