Skip to content

Issue #451: add MethodLength to checkstyle config #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Calixte merged 1 commit into from
Apr 17, 2026
Merged

Issue #451: add MethodLength to checkstyle config #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/checkstyle-checks.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@
<module name="MethodCount">
<property name="maxTotal" value="34"/>
</module>
<module name="MethodLength"/>
<module name="OuterTypeNumber"/>
<module name="RecordComponentNumber"/>

Expand Down
22 changes: 10 additions & 12 deletions net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,7 @@ private Composite createGeneralContents(Composite parent) {
mIncludeRuleNamesButton.setSelection(
CheckstylePluginPrefs.getBoolean(CheckstylePluginPrefs.PREF_INCLUDE_RULE_NAMES));

Label lblRebuildNote = new Label(includeRuleNamesComposite, SWT.NULL);
lblRebuildNote.setImage(CheckstyleUIPluginImages.HELP_ICON.getImage());
lblRebuildNote.setToolTipText(Messages.CheckstylePreferencePage_txtSuggestRebuild);
SWTUtil.addTooltipOnPressSupport(lblRebuildNote);
addRebuildNoteLabel(includeRuleNamesComposite);

//
// Create the "Include rule name" check box.
Expand All @@ -300,10 +297,7 @@ private Composite createGeneralContents(Composite parent) {
mIncludeModuleIdButton.setSelection(
CheckstylePluginPrefs.getBoolean(CheckstylePluginPrefs.PREF_INCLUDE_MODULE_IDS));

lblRebuildNote = new Label(includeModuleIdComposite, SWT.NULL);
lblRebuildNote.setImage(CheckstyleUIPluginImages.HELP_ICON.getImage());
lblRebuildNote.setToolTipText(Messages.CheckstylePreferencePage_txtSuggestRebuild);
SWTUtil.addTooltipOnPressSupport(lblRebuildNote);
addRebuildNoteLabel(includeModuleIdComposite);

//
// Create the "limit markers" check box and text field combination
Expand All @@ -329,10 +323,7 @@ private Composite createGeneralContents(Composite parent) {
gridData.widthHint = 30;
mTxtMarkerLimit.setLayoutData(gridData);

lblRebuildNote = new Label(limitMarkersComposite, SWT.NULL);
lblRebuildNote.setImage(CheckstyleUIPluginImages.HELP_ICON.getImage());
lblRebuildNote.setToolTipText(Messages.CheckstylePreferencePage_txtSuggestRebuild);
SWTUtil.addTooltipOnPressSupport(lblRebuildNote);
addRebuildNoteLabel(limitMarkersComposite);

//
// Create the "Run Checkstyle in background on full builds" check box.
Expand All @@ -350,6 +341,13 @@ private Composite createGeneralContents(Composite parent) {
return generalComposite;
}

private void addRebuildNoteLabel(Composite parent) {
Label lblRebuildNote = new Label(parent, SWT.NULL);
lblRebuildNote.setImage(CheckstyleUIPluginImages.HELP_ICON.getImage());
lblRebuildNote.setToolTipText(Messages.CheckstylePreferencePage_txtSuggestRebuild);
SWTUtil.addTooltipOnPressSupport(lblRebuildNote);
}

/**
* Creates the content regarding the management of check configurations.
*
Expand Down
Loading