[Work in Progress] Add Open Graph metadata tags to HackerWeb#59
Open
jabooth wants to merge 1 commit intocheeaun:masterfrom
Open
[Work in Progress] Add Open Graph metadata tags to HackerWeb#59jabooth wants to merge 1 commit intocheeaun:masterfrom
jabooth wants to merge 1 commit intocheeaun:masterfrom
Conversation
Issues: 1. Line endings to be fixed 2. Metadata not cleared on going back to main menu 3. Decide on what image to provide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a little hack this morning to try and add Open Graph tags to HackerWeb so that you would get rich previews when sharing hackerweb links with others (I often like to share the HW link rather than the original because HW is just such a cleaner experience to follow the comments!)
More on Open Graph: http://ogp.me/
Some guidance on integration: https://medium.com/@richardoosterhof/how-to-optimize-your-site-for-rich-previews-527ed13a6d69
This definitely isn't working correctly yet, but the gist is here. Not clear if I'll have time to finish refining this so instead of letting it bit rot I figured I'd at least show you what I have and see what you think.
Few thoughts:
Any thoughts appreciated! And great work on HW BTW, use it every day and love it.