Skip to content

Allow different date formatting like YYYY/MM/DD with Moment.js library.#31

Open
FR6 wants to merge 6 commits into
cheeaun:masterfrom
FR6:dateformat
Open

Allow different date formatting like YYYY/MM/DD with Moment.js library.#31
FR6 wants to merge 6 commits into
cheeaun:masterfrom
FR6:dateformat

Conversation

@FR6

@FR6 FR6 commented Dec 5, 2013

Copy link
Copy Markdown

No description provided.

Comment thread index.html Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, got weird white spaces after the code.

Comment thread index.html Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes please :)

@cheeaun

cheeaun commented Dec 5, 2013

Copy link
Copy Markdown
Owner

js/moment.min.js file should be deleted now that it's not used.

@cheeaun

cheeaun commented Dec 8, 2013

Copy link
Copy Markdown
Owner

@FR6 I've tried this PR on my local and seems to mess up a lot of things. Passing only year to MomentJS also sets the date and month which is rather unintended for this case.

@FR6

FR6 commented Dec 9, 2013

Copy link
Copy Markdown
Author

I see the problem, I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants