Update to current Revit code#6
Closed
harrymattison wants to merge 4 commits intochekalin-v:masterfrom
Closed
Conversation
Owner
|
Hi Harry, |
Contributor
Author
|
Hi Victor,
Please see this new PR
#7
Harry
…On Sat, Feb 20, 2021 at 11:13 AM Victor Chekalin ***@***.***> wrote:
Hi Harry,
I've made a lot of changes today in the repository. Please merge my changes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAROBGDMRAO27SCOSZKMSJDS77NSPANCNFSM4X57YQXA>
.
|
Contributor
Author
|
Hi Victor,
Are there any changes to this code that you'd like me to make?
Harry
On Sat, Feb 20, 2021 at 12:03 PM Harry Mattison <harrymattison@gmail.com>
wrote:
… Hi Victor,
Please see this new PR
#7
Harry
On Sat, Feb 20, 2021 at 11:13 AM Victor Chekalin ***@***.***>
wrote:
> Hi Harry,
> I've made a lot of changes today in the repository. Please merge my
> changes
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#6 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAROBGDMRAO27SCOSZKMSJDS77NSPANCNFSM4X57YQXA>
> .
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace obsolete code with ForgeTypeId
add transactions in test functions