fix(runtime): harden Windows host adapter defaults#28
Conversation
|
CTO review result: changes required before merge. The hard gate is not met because this PR changes executable runtime files but does not provide changed-file coverage showing >=95%, there are no CI checks on the branch, and the verification notes still report a failing Windows codex-adapter test while this PR changes packages/runtime/src/codex-adapter.ts. Please provide a real coverage report for the touched runtime files, get the affected runtime suites green, and resend for review. GitHub blocks formal self-request-changes here because the authenticated reviewer account is also the PR author, so this comment is the recorded gate decision. |
|
CTO review outcome: not mergeable yet. Coverage gate passes locally: 53 focused runtime tests passed and included-file line coverage is 96.17%. Blocking findings:
The Windows behavior changes themselves look directionally correct. Once the diff hygiene and capsule-scope issues are fixed, I can re-review quickly. |
Summary
SHELL=/bin/bashinside the Claude and Codex runtime adapters when the host platform is Windowsjunctionlinks for isolated agent-home directories when normal directory symlinks are blockedVerification
[pass]pnpm --filter @wanman/runtime exec vitest run src/__tests__/agent-home-manager.test.ts src/__tests__/claude-code.test.ts src/__tests__/codex-adapter.test.ts --coverage --coverage.reporter=text-summary --coverage.reporter=json-summary --coverage.include=src/agent-home-manager.ts --coverage.include=src/claude-code.ts --coverage.include=src/codex-adapter.ts53focused runtime tests passedLines 96.17% (226/235),Statements 93.33% (252/270),Branches 79.5% (159/200),Functions 89.58% (43/48)Coverage Notes
packages/runtime/src/agent-home-manager.ts:100%line coveragepackages/runtime/src/claude-code.ts:94.44%line coveragepackages/runtime/src/codex-adapter.ts:95.65%line coverage96.17%Task:
663cbe75Capsule:
37713a09