Add source span mapping to rich layout APIs#90
Open
somnai-dreams wants to merge 3 commits intochenglou:mainfrom
Open
Add source span mapping to rich layout APIs#90somnai-dreams wants to merge 3 commits intochenglou:mainfrom
somnai-dreams wants to merge 3 commits intochenglou:mainfrom
Conversation
somnai-dreams
force-pushed
the
codex/source-spans
branch
from
fe22efd to
a8e7c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track original-source boundaries through whitespace normalization so the rich layout APIs can map rendered positions back to the input text.
PreparedTextWithSegmentsgains per-segmentsegmentSourceOffsets/segmentSourceLengthsLayoutLinecarriessourceOffset/sourceLength(materialized lines are already the "pay for everything" API)LayoutLineRangeis unchanged —walkLineRangesstays leancursorToSourceOffset()/cursorRangeToSourceSpan()for opt-in mapping from geometry-only APIsMotivation
The rich path normalizes whitespace (collapsing runs, trimming edges,
\r\n→\n) which breaks the 1:1 correspondence between rendered and source positions. Consumers doing cursor placement, selection, or click-to-source currently have to reverse-engineer the normalization, which is fragile. The engine already makes these decisions internally — this surfaces them.Trade-offs
Adds two parallel arrays and a small amount of bookkeeping per line on the rich path only. The simple
prepare()/layout()hot path is unaffected.