Conversation
✅ Deploy Preview for cherry-on-tech-website-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ashleystringer
requested changes
Jul 27, 2026
| z-index: 999; | ||
| } | ||
|
|
||
| /* Active Overlay State */ |
Collaborator
There was a problem hiding this comment.
Good job on the dimming overlay, but I'm encountering a small bug where if you enlarge the screen size before closing the mobile menu, the dimming overlay will remain on top of the Desktop screen.
Dimming overlay for mobile screen:
Dimming overlay bug in desktop screen:
masuyama13
reviewed
Jul 27, 2026
masuyama13
left a comment
masuyama13
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me aside from the issue Ashley already pointed out.
ashleystringer
approved these changes
Jul 29, 2026
ashleystringer
left a comment
ashleystringer
left a comment
Collaborator
There was a problem hiding this comment.
Looks good with the desktop screen bug fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes...
Add dimming overlay when the navigation menu is opened in the mobile & tablet versions
Figma: https://www.figma.com/design/J56EPcWiwcSyTrxDf4EHG4/Design-System---Handoff-%7C-COT-Website-V2.5?node-id=247-37185
What I did...
How to test...
In the mobile/tablet version, click on the hamburger button. As the navigation menu flies open, the rest of the content page should have a dimming color.